src/HttpClient/Helpers/http_client.php (1)

12-34: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Wrap global helper functions with function_exists.

It is highly recommended to wrap global helper function declarations in if (!function_exists(...)) checks. This defensive programming practice prevents fatal redeclaration errors if the file is ever loaded multiple times by the autoloader or manual includes.

♻️ Proposed refactor

-/**
- * Creates single HTTP request client
- */
-function httpRequest(string $url): HttpClient
-{
-    return HttpClientFactory::createRequest($url);
-}
-
-/**
- * Creates multi HTTP request client
- */
-function httpMultiRequest(): HttpClient
-{
-    return HttpClientFactory::createMultiRequest();
-}
-
-/**
- * Creates async multi HTTP request client
- */
-function httpAsyncMultiRequest(callable $success, callable $error): HttpClient
-{
-    return HttpClientFactory::createAsyncMultiRequest($success, $error);
-}
+if (!function_exists('httpRequest')) {
+    /**
+     * Creates single HTTP request client
+     */
+    function httpRequest(string $url): HttpClient
+    {
+        return HttpClientFactory::createRequest($url);
+    }
+}
+
+if (!function_exists('httpMultiRequest')) {
+    /**
+     * Creates multi HTTP request client
+     */
+    function httpMultiRequest(): HttpClient
+    {
+        return HttpClientFactory::createMultiRequest();
+    }
+}
+
+if (!function_exists('httpAsyncMultiRequest')) {
+    /**
+     * Creates async multi HTTP request client
+     */
+    function httpAsyncMultiRequest(callable $success, callable $error): HttpClient
+    {
+        return HttpClientFactory::createAsyncMultiRequest($success, $error);
+    }
+}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/HttpClient/Helpers/http_client.php` around lines 12 - 34, Wrap each
global helper declaration—httpRequest, httpMultiRequest, and
httpAsyncMultiRequest—in function_exists guards so they are defined only when
not already declared, while preserving their existing signatures and delegation
to HttpClientFactory.

tests/Unit/HttpClient/Factories/HttpClientFactoryTest.php (1)

13-21: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Assert that the URL is correctly wired into the client.

While the tests successfully verify that a fresh HttpClient instance backed by a CurlAdapter is returned, they do not assert that the $url argument was properly passed down to the client configuration. Adding these assertions will improve confidence in the parameter wiring.

• tests/Unit/HttpClient/Factories/HttpClientFactoryTest.php#L13-L21: Add $this->assertSame('https://example.com', $httpClient1->url()); (and similarly for $httpClient2) to verify the URL was set.
• tests/Unit/HttpClient/Helpers/HttpClientHelperFunctionsTest.php#L12-L20: Add the same assertions here to ensure the helper perfectly forwards the URL.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/Unit/HttpClient/Factories/HttpClientFactoryTest.php` around lines 13 -
21, Update testHttpClientFactoryCreatesSingleRequest in
tests/Unit/HttpClient/Factories/HttpClientFactoryTest.php at lines 13-21 to
assert each returned client's url() matches its input URL; add equivalent URL
assertions in tests/Unit/HttpClient/Helpers/HttpClientHelperFunctionsTest.php at
lines 12-20 to verify helper forwarding.

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".